HTML: Constrain <form>-specific elements to BodyContext #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the APIs for creating what can be seen as “form-specific” HTML elements (such as `<input>` and `<fieldset>`) from an extension constrained to `HTML.FormContext` to the main `HTML.BodyContext` instead. This enables such elements to be mixed and matched with other body elements, such as `<div>`. While such elements might most often appear within forms, there’s nothing within the HTML spec that enforces that, so neither should Plot.
|
This is 🎉, 🚀, 🙌, and ❤️. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the APIs for creating what can be seen as “form-specific” HTML elements (such as
<input>and<fieldset>) from an extension constrained toHTML.FormContextto the mainHTML.BodyContextinstead. This enables such elements to be mixed and matched with other body elements, such as<div>.While such elements might most often appear within forms, there’s nothing within the HTML spec that enforces that, so neither should Plot.
Thanks to @daveverwer for the test case code 🙌